Fix flaky testPostFilterDisablesCountOptimization with concurrent search enabled #11674
Conversation
github-actions
bot
added
bug
ticheng-aws
force-pushed
the
cs-testPostFilterDisablesCountOptimization
branch
from
4f4626a to
80f6ee1
Compare
Compatibility status:Checks if related components are compatible with change 5b65415 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11674 +/- ##
============================================
+ Coverage 71.36% 71.39% +0.02%
+ Complexity 59205 59184 -21
============================================
Files 4906 4906
Lines 278198 278198
Branches 40422 40422
============================================
+ Hits 198537 198617 +80
+ Misses 63187 63055 -132
- Partials 16474 16526 +52 ☔ View full report in Codecov by Sentry. |
|
❕ Gradle check result for 80f6ee1: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
ticheng-aws
requested review from
abbashus,
adnapibar,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
ryanbogan and
sachinpkale
as code owners
ticheng-aws
requested review from
saratvemulapalli,
setiah,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
…rch enabled Signed-off-by: Ticheng Lin <[email protected]>
ticheng-aws
force-pushed
the
cs-testPostFilterDisablesCountOptimization
branch
from
80f6ee1 to
5b65415
Compare
…rch enabled (#11674) Signed-off-by: Ticheng Lin <[email protected]> (cherry picked from commit 316b60a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…rch enabled (#11674) (#11682) (cherry picked from commit 316b60a) Signed-off-by: Ticheng Lin <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…rch enabled (opensearch-project#11674) Signed-off-by: Ticheng Lin <[email protected]>
…rch enabled (opensearch-project#11674) Signed-off-by: Ticheng Lin <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
This flaky test uses
RandomIndexWriterto add random number of documents to the search index. As long as the score_count in the concurrent search case matches the non-concurrent search case, we can tune the expected value for min_score/min_score_count to make it less sensitive. I ran the new changes1000+times to make sure that they all passed.Related Issues
Resolves #10139
Check List
New functionality includes testing.New functionality has been documented.New functionality has javadoc addedFailing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Commit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.